-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fingerprinting import issue #317
base: master
Are you sure you want to change the base?
Fix fingerprinting import issue #317
Conversation
This is done for backward compatibility purposes, since we want the same behavior as the function deleted in Scrapy 2.12.0.
Scrapy 2.12.0 added JsonResponse, which is the class any JSON response is instantiated as. We therefore needed to use it for our test.
After testing the |
I think whatever works best for you. |
Scrapy removed support for Python 3.8
The integration tests seem to working in the CI, although I haven't been able to reproduce it locally (through the commands directly or using This should now be ready for code reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The only thing I think is missing is updating the README accordingly, to replace the old configuration instructions with the new ones.
I just did the fixes you requested, let me know if I missed something! |
|
5a09f6d
to
5f0fc1c
Compare
I just fixed that, the tests should now pass |
This CR is a great update, thanks ! |
Goal
The goal of this PR is to do the changes explained here: #311 (comment) and to solve #316
I do this by copying the Scrapy code for fingerprinting to keep backwards compatibility, and I also added a new fingerprinter using the newer function.