Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an exception instead of returning string error message #19

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions bitfinex/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@
TIMEOUT = 5.0


class BitfinexException(Exception):
pass


class TradeClient:
"""
Expand Down Expand Up @@ -84,7 +87,7 @@ def place_order(self, amount, price, side, ord_type, symbol='btcusd', exchange='
try:
json_resp['order_id']
except:
return json_resp['message']
raise BitfinexException(json_resp['message'])

return json_resp

Expand All @@ -107,7 +110,7 @@ def delete_order(self, order_id):
try:
json_resp['avg_execution_price']
except:
return json_resp['message']
raise BitfinexException(json_resp['message'])

return json_resp

Expand Down Expand Up @@ -146,7 +149,7 @@ def status_order(self, order_id):
try:
json_resp['avg_execution_price']
except:
return json_resp['message']
raise BitfinexException(json_resp['message'])

return json_resp

Expand Down