Couple more simplifications

scottcain · Dec 18, 2024 · 258cf5c · 258cf5c
1 parent 3df29f8
commit 258cf5c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 31 deletions.
diff --git a/lib/src/components/GenericGeneSeqPanel.tsx b/lib/src/components/GenericGeneSeqPanel.tsx
@@ -32,11 +32,13 @@ const GenericGeneSeqPanel = observer(function ({
 }) {
   const [result, setResult] = useState<Feature[]>();
   const [error, setError] = useState<unknown>();
-  const [{ sequenceFeatureDetails }] = useState(() =>
-    Model.create({
+  const [{ sequenceFeatureDetails }] = useState(() => {
+    const model = Model.create({
       sequenceFeatureDetails: {},
-    }),
-  );
+    });
+    model.sequenceFeatureDetails.setUpDownBp(500);
+    return model;
+  });
 
   useEffect(() => {
     // eslint-disable-next-line @typescript-eslint/no-floating-promises
@@ -100,12 +102,7 @@ const GenericGeneSeqPanel = observer(function ({
         {sequenceFeatureDetails.feature ? (
           <GenericSeqPanel
             refseq={refseq}
-            start={start}
-            end={end}
             fastaurl={fastaurl}
-            gene={gene}
-            urltemplate={urltemplate}
-            nclistbaseurl={nclistbaseurl}
             model={sequenceFeatureDetails}
           />
         ) : null}

diff --git a/lib/src/components/GenericSeqPanel.tsx b/lib/src/components/GenericSeqPanel.tsx
@@ -10,22 +10,12 @@ import { SequenceFeatureDetailsModel } from "@jbrowse/core/BaseFeatureWidget/Seq
 type Bundle = Awaited<ReturnType<typeof assembleBundle>>;
 
 const GenericSeqPanel = observer(function ({
-  nclistbaseurl,
   fastaurl,
   refseq,
-  start,
-  end,
-  gene,
-  urltemplate,
   model,
 }: {
-  nclistbaseurl: string;
   fastaurl: string;
   refseq: string;
-  start: number;
-  end: number;
-  gene: string;
-  urltemplate: string;
   model: SequenceFeatureDetailsModel;
 }) {
   const [result, setResult] = useState<Bundle>();
@@ -55,18 +45,7 @@ const GenericSeqPanel = observer(function ({
         setError(e);
       }
     })();
-  }, [
-    refseq,
-    feature,
-    upDownBp,
-    intronBp,
-    gene,
-    start,
-    end,
-    fastaurl,
-    urltemplate,
-    nclistbaseurl,
-  ]);
+  }, [intronBp, fastaurl, refseq, upDownBp, feature]);
 
   if (error) {
     return <div style={{ color: "red" }}>{`${error}`}</div>;