Remove users modal Implemented #934
Conversation
|
@shivareddy6 I have also implemented the remove use functionality for the orgs , Recording.2023-10-31.225842_compressed.mp4 |
|
same here, please resolve the conflicts |
|
@shivareddy6 I have resolved this conflict too..Pls merge it after merging the add modal pr. |
| @@ -15,6 +21,28 @@ const useStyles = makeStyles(theme => ({ | |||
|
|
|||
| function Users() { | |||
| const classes = useStyles(); | |||
| const [modalOpenAdmin, setModalOpenAdmin] = useState(false); | |||
There was a problem hiding this comment.
You are not utilising any of these states in this component expect for sending them as props right, so i suggest you redefine all the states related modal in OrgUsers component itself.
This will:
- Improve locality of the states and is easy to track their functionality
- Avoid un-necessary re-renders in this component due to the state change of states related to some other component
| const closeContriModal = () => { | ||
| setModalOpenContr(false); | ||
| }; | ||
| const handleAddContri = () => { |
There was a problem hiding this comment.
same goes for these functions
the UI implementation is good, but can you include the backend details as well Please ask if you have any doubts. |
|
@shivareddy6 thanks for the review I would work to incorporate the suggested changes. |
Implemented the modal to remove users of a org using
Description
Implemented modal to remove users from a organization by entering the user handle and called removeOrgUser function on submit of the modal.
Related Issue
#890 solved
Motivation and Context
How Has This Been Tested?
Tested locally on my system.
Screenshots or GIF (In case of UI changes):
Types of changes
Checklist: