Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title step not updating bug fixed. #923

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

turingAlan
Copy link

Description

Previously the onChange function which was responsible for the step update was being passed to the onChange prop of Stepper component of Material UI which was not causing any change to the current step. What I did is to pass that onChange function to the onClick of the StepButton which caused the active step value to change.

Related Issue

This PR closes #922 .

Motivation and Context

The changes that user did on title of any step only led to the change in the title of the first step as the active step index was not getting updated on the change in the active.

How Has This Been Tested?

I tested all possible ways user can edit the steps and it is working perfectly,

Screenshots or GIF (In case of UI changes):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • All new and existing tests passed.

@turingAlan
Copy link
Author

@shivareddy6 @ABHISHEK-PANDEY2 please review this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Step title text input stuck at first step.
1 participant