Implemented a working production UI dockerfile for Bassa #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmehant
added
bug
enhancement
GSoC-2019
kmehant
force-pushed
the
prod-UI-dockerfile
branch
from
b70db0f to
bf2edac
Compare
|
@agentmilindu @vivonk Please review! |
|
Fixes #745 |
JaDogg
reviewed
Jul 18, 2019
JaDogg
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made changes to production Dockerfile for Bassa UI. I worked on getting the built folder dist in the initial docker build stage and copied that to nginx container and finally had used nginx server to host the Bassa UI static site pages at
localhost:80Image size: ~22MB
Related Issue
#796
Motivation and Context
We need a working production level Dockerfile for Bassa UI.
How Has This Been Tested?
This has been tested locally using docker and docker-compose
Types of changes
Checklist: