-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI via Github actions #68
Conversation
e0006f8
to
5d4758b
Compare
You are changing way too much infrastructure in one PR. I am not going to merge this as it is. About the CI system:Having two CI systems just unnecessary overhead. What are the benefits of Github actions above Travis? About Code Formating:What is the benefit of flake8 above autopep8? About
|
I moved the .gitignore into #70, the remaining are: CI with linting and make it pass (fix issues detected by that CI). IMO those belong together but I can split this further if you tell me how you'd like your PRs.
Travis needs to be set up, GHA is enabled for all repos by default (it seems it was explicitly disabled here, or the PR must be accepted first though), especially useful for running the tests in branches before opening a PR.
autopep8 changes code according to errors reported by flake8. So it is a formatter while flake8 is a linter. So you can't compare them. |
Thanks.
I'd like to squash and merge the PR's. So I think it's a good idea to split this further. What about:
CI System
As far as I remember I did not explicitly disable it but never used it. Github CI cam after I started to use Travis. Branches and PR's are done by Travis as well, and as stated, was there before.
Especially the setup is a question of what are you used to.
For me, this looks quite chaotic 😉
This seems to be a good reason. Please draft a separate pull request for the CI, to discuss the details. Code formating
Ok, I wasn't aware of the difference. As already stated, please do a sperate PR. I will merge this first, and the CI one later. Please also state the errors, that are detected by flake8 |
Doublecheck "Settings"->"Actions"->"Enable local and third party Actions for this repository", but it is possible, that it is automatically enabled once any action is defined in the repo, i.e. after this is merged
I mean: In my fork I'd have to set up travis myself before branches are build, this (minor) work isn't required for GHA.
Give it a chance. Especially the matrix feature is better than all others as you can have different matrices which I found lacking in other CIs for more complex test workflows. Anyway, rebased this PR removing all unrelated commits and moved those to separate PRs. Try merging this first, and observe the failures by the static_analysis job (view in the "actions" tab above) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Especially the matrix feature is better [...]
interesting. I do like it somehow. However, there are two questions left. Once they are clarified we can merge this.
yes, please. At best as part of this PR. |
Added the bages with links to the would-be status pages. Flying blind here as they haven't run yet so got to recheck once this is merged |
Thanks. |
This adds CI tests via Github actions where it installs scorep and this module and runs
test/test.py
It also checks formatting (as per clang-format-9) and for Python issues (via flake8)
See commits for details