Introduce a component for a sidebar overlay #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used to open a filter sidebar on small devices in an overlay. This doesn't use the existing overlay component, as some implementations require this filter overlay on top of an already open overlay of which there can be only one. Fixes: SE-13735
idlira
approved these changes
Jan 9, 2025
sabieber
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
This is not strictly targeted at only containing filters, right?
Maybe if we chose a more generic name (like sidebar overlay or something similar) we could also re-use it for similar features/use-cases like the OX product watchlist (i mean, its re-usable like it is but the chosen name does not really suggest that its as flexible as it really is) 😊
src/main/resources/default/assets/common/scripts/filterOverlay.js.pasta
Outdated
Show resolved
Hide resolved
Fixes: SE-13735
Fixes: SE-13735
Fixes: SE-13735
Fixes: SE-13735
jmuscireum
changed the title
sabieber
approved these changes
Jan 9, 2025
src/main/resources/default/assets/common/styles/filterOverlay.scss
Outdated
Show resolved
Hide resolved
src/main/resources/default/assets/common/scripts/sidebar-overlay.js.pasta
Outdated
Show resolved
Hide resolved
The 'namespace' (sirius.sidebarOverlay.*) already contains the important information. Fixes: SE-13735
mkeckmkeck
approved these changes
Jan 9, 2025
Also replace some border widths with variables. Fixes: SE-13735
sabieber
approved these changes
Jan 9, 2025
ymo-sci
approved these changes
Jan 10, 2025
It uses Mustache-Syntax and gets proper highlighting and formatting this way. |
This is breaking, as --sci-border-width needs to be replaced by --sci-border-width-1 Fixes: SE-13735
jmuscireum
added
the
💣 BREAKING CHANGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This can be used to open a filter sidebar on small devices in an overlay. This doesn't use the existing overlay component, as some implementations require this filter overlay on top of an already open overlay of which there can be only one.
Breaking
CSS Variable
--sci-border-widthneeds to be replaced by--sci-border-width-1.Additional Notes
Checklist