Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix t:radio - correct classes and according selector. #1426

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

ymo-sci
Copy link
Contributor

@ymo-sci ymo-sci commented Jun 5, 2024

input-required does not exist anymore in BS5, from-text should be form-text Many radio-buttons with a required-* are not useful. With this approach you can add a required-* to a div with a t:radio inside as well, but the * will only occur on the heading label, not at the selectable values.
Bildschirmfoto 2024-06-05 um 16 32 44

Description

Additional Notes

  • This PR fixes or works on following ticket(s): SE-13684
  • This PR is related to PR:

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

input-required does not exist anymore in BS5, from-text should be form-text
Many radio-buttons with a required-* are not useful.
With this approach you can add a required-* to a div with a t:radio inside as well, but the * will only occur on the heading label, not at the selectable values.

- fixes: SE-13684
@ymo-sci ymo-sci added 🐛 Bugfix Contains only a small fix for an existing bug 👶🏻 Trivial Easy to review labels Jun 5, 2024
@ymo-sci ymo-sci merged commit 4b9876d into develop Jun 6, 2024
5 checks passed
@ymo-sci ymo-sci deleted the feature/ymo/radio branch June 6, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bugfix Contains only a small fix for an existing bug 👶🏻 Trivial Easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants