Optimizes some system generates queries based on casing annotations #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When all values stored in a field are stored e.g. lowercased, we do not need to query case-insensitively. This can give a small speedup. - When all values in a field are stored e.g. lowercased, we do not need to query with an value containing upper case characters. We apply auto-magical case adaption on some cases where the framework generates queries. So we create the chance of actually finding an result, even if the input did not match the actual db field. This is relevant, e.g. for the Sirius biz virtual filesystem backend ui. There, the normalized filename field of a sql blob containing only lowercase characters might get queried by user input containing the exact filename. By this adaption, we are able to find the blob. - For regular API usage, such magic from framework is not desired. If required, apply it by yourself when creating queries. Fixes: SIRI-951
Fixes: SIRI-951
sabieber
approved these changes
Apr 9, 2024
idlira
approved these changes
Apr 9, 2024
mko-sci
approved these changes
Apr 9, 2024
jakobvogel
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses lowercase and uppercase field annotations to optimize queries
to query case-insensitively. This can give a small speedup.
to query with an value containing upper case characters. We apply auto-magical
case adaption on some cases where the framework generates queries. So we create
the chance of actually finding an result, even if the input did not match the actual db field.
This is relevant, e.g. for the Sirius biz virtual filesystem backend ui. There, the normalized
filename field of a sql blob containing only lowercase characters might get queried by user input
containing the exact filename. By this adaption, we are able to find the blob.
yourself when creating queries.