Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps sirius libs and applies breaking changes #2065

Merged
merged 8 commits into from
Dec 17, 2024
Merged

Bumps sirius libs and applies breaking changes #2065

merged 8 commits into from
Dec 17, 2024

Conversation

idlira
Copy link
Contributor

@idlira idlira commented Dec 16, 2024 •
edited
Loading

Description

Marking as BREAKING since this applies a breaking change from sirius-biz.

Additional Notes

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices

@idlira
Bumps sirius libs
43ac4d0 
Fixes: SIRI-1039
@idlira
Do not return pre-loaded mongo refs
38c2fe3 
But force a cached search using the ID inside the ref. This is exactly what we were trying to avoid with scireum/sirius-db@01b9793

Fixes: SIRI-1039
@idlira
Compares tenants using their IDs
74827f5 
Fixes: SIRI-1039
@idlira
Replaces calls of fetchValue() to either one of the new variants
35cdb77 
Fixes: SIRI-1039
@idlira
Uses fetchTenant whenever possible
9399897 
which uses the internal cache instead of relying on the value set at the reference

Fixes: SIRI-1039
@idlira
Retrieves the tenant from the cache via the tenants part
fe31cc6 
Fixes: SIRI-1039
@idlira idlira added 💣 BREAKING CHANGE Contains non-backwards compatible changes to public methods or changes the behavior of existing code ⬆️ Dependencies Pull requests that update a dependency file labels Dec 16, 2024
@idlira
Uses a forced fetch
d4f6793 
as casting is causing some trouble. Since this code validates SAML users on login, an extra fetch won't harm.

Fixes: SIRI-1039
sabieber
sabieber approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@sabieber sabieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks

src/main/java/sirius/biz/storage/legacy/VirtualObjectVersion.java Outdated Show resolved Hide resolved
@idlira
Extracts a variable
aadf4c4 
so its clear the object is force-fetched and reused

Fixes: SIRI-1039
@idlira idlira merged commit 728a253 into develop Dec 17, 2024
3 checks passed
@idlira idlira deleted the ili/SIRI-1039 branch December 17, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scireum-mbo scireum-mbo scireum-mbo approved these changes

@jmuscireum jmuscireum jmuscireum approved these changes

@sabieber sabieber sabieber approved these changes

Assignees
No one assigned
Labels
💣 BREAKING CHANGE Contains non-backwards compatible changes to public methods or changes the behavior of existing code ⬆️ Dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@idlira @sabieber @jmuscireum @scireum-mbo