Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes system-files not being ignored by ZIP-native extractor when executing an import-job #2059

Merged
merged 11 commits into from
Dec 11, 2024
Merged

Fixes system-files not being ignored by ZIP-native extractor when executing an import-job #2059

merged 11 commits into from
Dec 11, 2024

Conversation

scireum-mbo
Copy link
Contributor

@scireum-mbo scireum-mbo commented Dec 9, 2024 •
edited by idlira
Loading

Additional Notes

  • This PR fixes or works on following ticket(s): SIRI-1028

Additional PRs

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@scireum-mbo scireum-mbo added 🐛 Bugfix Contains only a small fix for an existing bug 👶🏻 Trivial Easy to review labels Dec 9, 2024
@scireum-mbo scireum-mbo mentioned this pull request Dec 10, 2024
Merged
3 tasks
@scireum-mbo
Implements new methods isConsideredHidden and isConsideredMetadata
80a2212 
Replaces all occurrences of string.startsWith(".") with isConsideredHidden as well as all occurrences of string.startsWith("__MACOSX") with the isConsideredMetadata method.

Fixes: SIRI-1028
@scireum-mbo
Removes the list of filenames due to it being moved to siri-kernel
6855a52 
Fixes: SIRI-1028
@scireum-mbo scireum-mbo added the 🕔 Wait for sirius Needs new version from another sirius lib to work label Dec 10, 2024
@scireum-mbo
Merge branch 'develop' into feature/mbo/SIRI-1028
fbba26f
@scireum-mbo
Implements a check for the list of imported files
19c709c 
This is done to check if the imported file is hidden or a metadata file

Fixes: SIRI-1028
@scireum-mbo
Bumps sirius-kernel
cf2847c 
Fixes: SIRI-1028
@scireum-mbo scireum-mbo removed 🕔 Wait for sirius Needs new version from another sirius lib to work 👶🏻 Trivial Easy to review labels Dec 11, 2024
@scireum-mbo
Removes check to be used in a different place
0091520 
Fixes: SIRI-1028
@scireum-mbo
Implements check for hidden and metadata files for zip entries
f024063 
Also removes unused java.util.List import

Fixes: SIRI-1028
@scireum-mbo scireum-mbo merged commit 5545cf1 into develop Dec 11, 2024
3 checks passed
@scireum-mbo scireum-mbo deleted the feature/mbo/SIRI-1028 branch December 11, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhaScireum fhaScireum fhaScireum left review comments

@mko-sci mko-sci mko-sci approved these changes

@idlira idlira idlira approved these changes

@sabieber sabieber sabieber approved these changes

Assignees
No one assigned
Labels
🐛 Bugfix Contains only a small fix for an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@scireum-mbo @sabieber @fhaScireum @idlira @mko-sci