Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated package with Python 3.13 deprecated decorator #537

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Nov 16, 2023

This is available in typing_extensions already and will be in CPython 3.13, and unlike the third-party package, typing tools can tell this is deprecated (mypy soon, some other typing checkers already support it).

This also enables us to start testing on 3.12 in a followup (fixes a warning importing Traversable).

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (70deb39) 95.89% compared to head (c343fda) 95.80%.

Files Patch % Lines
src/particle/_compat/typing.py 90.90% 1 Missing ⚠️
src/particle/_compat/warnings.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #537      +/-   ##
==========================================
- Coverage   95.89%   95.80%   -0.09%     
==========================================
  Files          31       33       +2     
  Lines        1389     1407      +18     
==========================================
+ Hits         1332     1348      +16     
- Misses         57       59       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii force-pushed the henryiii/fix/deprecated branch from 2ee322d to c343fda Compare November 16, 2023 16:47
@eduardo-rodrigues eduardo-rodrigues added the ⚙️ enhancement New feature or request label Nov 20, 2023
@henryiii henryiii merged commit 20d7430 into master Nov 21, 2023
12 checks passed
@henryiii henryiii deleted the henryiii/fix/deprecated branch November 21, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants