Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ToyResult and ToyManager classes #20

Merged
merged 41 commits into from
Feb 15, 2020
Merged

add ToyResult and ToyManager classes #20

merged 41 commits into from
Feb 15, 2020

Conversation

marinang
Copy link
Member

@marinang marinang commented Jan 24, 2020 •
edited
Loading

ResultToy is a container of the result of the toys and contains:

  • the value of POI at generation
  • the best fitted values of the POI
  • the likelihood evaluated at the best fitted values of POI
  • the values of the POI to scan
  • the likelihood evaluated at the values in the previous bullet

ToyManager is a dictionary like container of ToyResult object. It can generate and fit the toys and can save the results in a yml file and can read it back (see #18).
The FrequentistCalculator is now also a subclass of the ToyManager.

marinang added 19 commits January 24, 2020 19:06
@marinang
add print statements to figure out why the windows build fails
1c128a9
@marinang
add another print statement to figure out why the windows build fails.
1d36862
@marinang
windows failure investigation #3
ccd95f2
@marinang
windows failure investigation #4
f3c2f84
@marinang
remove __eq__ in POIarray
91829f5
@marinang
windows failure investigation 5
31355d7
@marinang
windows failure investigation 6
a6071b0
@marinang
windows failure investgation 7
ddaabb4
@marinang
windows failure investigation 8
063ad52
@marinang
windows failure investigation 9 (print hash of POI, and POIarray)
6584c06
@marinang
windows failure investigation 10
236b368
@marinang
windows failure investigation 11 (cause is probably hash(float32) =! …
c4d568f 
…hash(float64).
@marinang
impose the np.float64 dtype in values of Parameter
0f9a915
@marinang
remove print statements in frequentist_calculator.py
0e009a5
@marinang
add tests for classes in toysutils.py
f3eb199
@marinang
add upper limits test with frequentists calculator
f3da725
@marinang
move toy generation and fit to ToyManager
0f607d5
@marinang
add tests for confidence intervals with frequentist calculator
f6e927c
@marinang
fix number of scan points in test_confidence_interval to be the same …
05464c3 
…as in the yml file
@marinang marinang changed the title WIP: add ToyResult and ToyManager classes add ToyResult and ToyManager classes Jan 26, 2020
@marinang
Copy link
Member Author

@eduardo-rodrigues ready for review when you have time :).

@eduardo-rodrigues
Copy link
Member

Hi @marinang, I will do it but only after Wednesday this week … Sorry for the delay.

eduardo-rodrigues
eduardo-rodrigues approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@eduardo-rodrigues eduardo-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a big PR, "for a change" :D.
I didn't have much to say, but hopefully 1-2 comments were useful.
Good job!

@marinang
Copy link
Member Author

marinang commented Feb 4, 2020

Thank you @eduardo-rodrigues. I will make the appropriate changes.

@marinang marinang merged commit e759346 into master Feb 15, 2020
@marinang marinang deleted the mm_savetoys branch February 15, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardo-rodrigues eduardo-rodrigues eduardo-rodrigues approved these changes

Assignees

@eduardo-rodrigues eduardo-rodrigues

Labels
hypotests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marinang @eduardo-rodrigues