-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Python 3.12 support #477
Conversation
* Add Python 3.12 to CI test matrix. * Default to Python 3.12 in GitHub Actions based workflows. * Use Python 3.12 in pre-commit.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #477 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2093 2093
Branches 346 346
=========================================
Hits 2093 2093 ☔ View full report in Codecov by Sentry. |
The Python 3.12-only error that is currently being seen from Error:$ python utils/create_ntuples.py
File "/home/runner/work/cabinetry/cabinetry/example.py", line 3, in <module>
import cabinetry
File "/opt/hostedtoolcache/Python/3.12.3/x64/lib/python3.12/site-packages/cabinetry/__init__.py", line 7, in <module>
import cabinetry.fit as fit # noqa: F401
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/hostedtoolcache/Python/3.12.3/x64/lib/python3.12/site-packages/cabinetry/fit/__init__.py", line 6, in <module>
import iminuit
File "/opt/hostedtoolcache/Python/3.12.3/x64/lib/python3.12/site-packages/iminuit/__init__.py", line 24, in <module>
from iminuit.minuit import Minuit
File "/opt/hostedtoolcache/Python/3.12.3/x64/lib/python3.12/site-packages/iminuit/minuit.py", line 6, in <module>
from iminuit import util as mutil
File "/opt/hostedtoolcache/Python/3.12.3/x64/lib/python3.12/site-packages/iminuit/util.py", line 11, in <module>
from iminuit import _repr_html, _repr_text, _deprecated
File "/opt/hostedtoolcache/Python/3.12.3/x64/lib/python3.12/site-packages/iminuit/_deprecated.py", line 2, in <module>
from numpy import VisibleDeprecationWarning
ImportError: cannot import name 'VisibleDeprecationWarning' from 'numpy' (/opt/hostedtoolcache/Python/3.12.3/x64/lib/python3.12/site-packages/numpy/__init__.py) is due to scikit-hep/iminuit#977 (comment), but is getting caused by the pre-release of |
* List installed packages during CI.
4d1b69d
to
15104b7
Compare
@alexander-held this should be ready for review now given that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this all looks good to me!
related previous PR for 3.11 was #400
* add Python 3.12 PyPI trove classifier
* add Python 3.12 to CI
* add workflow dispatch trigger to CI
* list installed Python packages in CI
Resolves #446