scikit-hep · henryiii · Dec 19, 2020 · Dec 7, 2020 · Dec 19, 2020 · Dec 19, 2020
diff --git a/extern/assert b/extern/assert
diff --git a/extern/config b/extern/config
diff --git a/extern/core b/extern/core
diff --git a/extern/histogram b/extern/histogram
diff --git a/extern/mp11 b/extern/mp11
diff --git a/src/boost_histogram/tag.py b/src/boost_histogram/tag.py
@@ -107,9 +107,6 @@ def __init__(self, value):
         self.value = value
 
     def __call__(self, axis):
-        if self.value < -2:
-            raise IndexError("Index cannot be less than -1")
-
         return self.value
 
 

diff --git a/tests/test_histogram_indexing.py b/tests/test_histogram_indexing.py
@@ -205,6 +205,29 @@ def test_mix_value_with_slice_2():
     assert_array_equal(h2.shape, (5, 2, 2))
 
 
+def test_one_sided_slice():
+    h = bh.Histogram(bh.axis.Regular(4, 1, 5))
+    h.view(True)[:] = 1
+
+    assert h[sum] == 6  # 4 (internal bins) + 2 (flow bins)
+    assert h[bh.tag.at(-1) : bh.tag.at(5) : sum] == 6  # keeps underflow, keeps overflow
+
+    # check that slicing without bh.sum adds removed counts to flow bins
+    assert_array_equal(h[1:3].view(True), [2, 1, 1, 2])
+
+    assert h[0::sum] == 5  # removes underflow, keeps overflow
+    assert h[:4:sum] == 5  # removes overflow, keeps underflow
+    assert h[0:4:sum] == 4  # removes underflow and overflow
+
+    assert h[bh.loc(1) :: sum] == 5  # remove underflow
+    assert h[: bh.loc(5) : sum] == 5  # remove overflow
+    assert h[bh.loc(1) : bh.loc(5) : sum] == 4  # removes underflow and overflow
+
+    assert h[bh.loc(0) :: sum] == 6  # keep underflow
+    assert h[: bh.loc(10) + 1 : sum] == 6  # keep overflow
+    assert h[bh.loc(0) : bh.loc(10) + 1 : sum] == 6
+
+
 def test_repr():
     assert repr(bh.loc(2)) == "loc(2)"
     assert repr(bh.loc(3) + 1) == "loc(3) + 1"
+1 −3		checks/config.jam
+5 −2		include/boost/config/detail/suffix.hpp
+6 −4		include/boost/config/stdlib/dinkumware.hpp
+3 −1		include/boost/config/stdlib/libstdcpp3.hpp
+2 −2		include/boost/version.hpp
+14 −0		doc/history.qbk
+8 −0		doc/rationale.qbk
+24 −4		include/boost/histogram/algorithm/reduce.hpp
+2 −1		meta/libraries.json
+84 −10		test/algorithm_reduce_test.cpp
+1 −1		CMakeLists.txt
+2 −2		README.md
+6 −2		appveyor.yml
+31 −0		doc/mp11/algorithm.adoc
+5 −0		doc/mp11/changelog.adoc
+11 −0		include/boost/mp11/algorithm.hpp
+48 −4		include/boost/mp11/detail/mp_map_find.hpp
+0 −18		include/boost/mp11/utility.hpp
+1 −1		include/boost/mp11/version.hpp
+4 −0		test/Jamfile
+33 −0		test/mp_map_find_2.cpp
+34 −0		test/mp_map_find_3.cpp
+49 −0		test/mp_pairwise_fold.cpp
+18 −0		test/mp_pairwise_fold_q.cpp