Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hash of HashableDict #3355

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix: hash of HashableDict #3355

merged 1 commit into from
Dec 19, 2024

Conversation

pfackeldey
Copy link
Collaborator

Python's builtin hash function takes only 1 argument, not 2.

@pfackeldey pfackeldey requested a review from jpivarski December 19, 2024 18:58
jpivarski
jpivarski approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is correct. I wonder how it never came up before? This bug would be hit as soon as any HashableDict is ever created.

@pfackeldey
Copy link
Collaborator Author

Yeah, I don't know, I stumbled over this because my editor complained.

@pfackeldey pfackeldey merged commit d5e7493 into main Dec 19, 2024
39 checks passed
@pfackeldey pfackeldey deleted the pfackeldey/fix_hash_of_HashableDict branch December 19, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfackeldey @jpivarski