Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upstream API changes in cuDF 24.10 #3309

Closed
wants to merge 4 commits into from
Closed

fix: Upstream API changes in cuDF 24.10 #3309

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e100461
Upstream API changes in cuDF 24.10
Nov 19, 2024
0bab17b
allow both old and new
martindurant Dec 2, 2024
ce6026f
Merge branch 'main' into new_cudf
martindurant Dec 2, 2024
d267b52
style: pre-commit fixes
pre-commit-ci[bot] Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion awkward-cpp/rapidjson
Open in desktop
Submodule rapidjson updated 1 files
+2 −0 include/rapidjson/document.h
5 changes: 3 additions & 2 deletions src/awkward/contents/listoffsetarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2005,7 +2005,7 @@ def _to_cudf(self, cudf: Any, mask: Content | None, length: int):
index = self._offsets.raw(cupy).astype("int32")
buf = cudf.core.buffer.as_buffer(index)
ind_buf = cudf.core.column.numerical.NumericalColumn(
buf, index.dtype, None, size=len(index)
data=buf, dtype=index.dtype, mask=None, size=len(index)
)
cont = self._content._to_cudf(cudf, None, len(self._content))
if mask is not None:
Expand All @@ -2027,7 +2027,8 @@ def _to_cudf(self, cudf: Any, mask: Content | None, length: int):
)

return cudf.core.column.lists.ListColumn(
length,
size=length,
data=None,
mask=m,
children=(ind_buf, cont),
dtype=cudf.core.dtypes.ListDtype(cont.dtype),
Expand Down
2 changes: 1 addition & 1 deletion src/awkward/operations/ak_to_cudf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ def to_cudf(
"""
import cudf

return cudf.Series(array.layout._to_cudf(cudf, None, len(array)))
return cudf.Series._from_column(array.layout._to_cudf(cudf, None, len(array)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This functionality has become private. Is it something we're not supposed to do anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be worth finding the git blame on this, and asking on their repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the PR rapidsai/cudf#16454

Loading