Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve deployment environment UX #2742

Merged
merged 5 commits into from
Oct 5, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Oct 5, 2023

After becoming more familiar with environments, prompted by a comment made by @henryiii, I've decided to share our deployment environments across targets, and rename them accordingly. This should slightly improve UX.

I've also added URLs to the PyPI deployments, and a linter for the YML files in GH.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #2742 (a10e70b) into main (6dee1ea) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@agoose77 agoose77 changed the title ci: improve environments ci: improve deployment environment UX Oct 5, 2023
@agoose77 agoose77 requested a review from jpivarski October 5, 2023 17:11
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my understanding that this will make GitHub recognize the environment as a PyPI deployment and add more buttons. We could use more buttons.

I think it's ready to merge!

@agoose77 agoose77 enabled auto-merge (squash) October 5, 2023 21:04
@agoose77 agoose77 disabled auto-merge October 5, 2023 21:06
@agoose77 agoose77 merged commit f96b72c into main Oct 5, 2023
38 checks passed
@agoose77 agoose77 deleted the agoose77/ci-improve-environments branch October 5, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants