-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add recursive
argument to expected_from_buffers
#2724
Conversation
56c1a1c
to
98ab307
Compare
Codecov Report
Additional details and impacted files
|
814ea10
to
5eb02cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any examples in this PR in which the new recursive
argument gets used, but in principle it could be useful to have.
The default should be recursive=True
, as you have it here, since its primary use-case is to find out what the containers
needs to have, and that's a question for a whole tree, not a single node.
The test file uses both variations :) |
In the work to support buffer-shape touching in dask-awkward, I found it useful to be able to disable recursion in
expected_from_buffers
in order to identify the buffers associated directly with each form node. I think this has merit, so I've created this PR.