Improved validation regular expressions to support specific attribute names #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow validation of directive-style attributes like ':class' and '@scroll.window' by updating the attribute name validation pattern.
Add test cases to verify DomValidator accepts attribute: - ':' prefix for binding attributes (e.g. :class) - '@' prefix for event handlers (e.g. @scroll.window)
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Package Version ReportThe following packages have been updated: |
- Implement custom GatherUsedImportedElementsVisitor class to replace removed analyzer functionality - Remove unused import from import_assist.dart - Replace deprecated 'enclosingElement' with 'enclosingElement3' - Add curly braces to if statement in component_assist.dart
- Bump `serverpod` to `2.3.0` and `jaspr` to `0.16.3` - Update CHANGELOG.md to reflect version 0.5.0 changes
- Bump `serverpod`, `serverpod_auth_client`, and `serverpod_client` to `2.3.0` across multiple files. - Ensure compatibility with the latest version of the serverpod packages.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
==========================================
+ Coverage 75.80% 75.86% +0.05%
==========================================
Files 129 129
Lines 5481 5486 +5
==========================================
+ Hits 4155 4162 +7
+ Misses 1326 1324 -2 ☔ View full report in Codecov by Sentry. |
- Update generated files to reflect the renaming of _Modules to Modules and improved class structure using 'serverpod generate' command.
schultek
reviewed
Jan 2, 2025
schultek
reviewed
Jan 2, 2025
- Update CHANGELOG.md files to reflect the latest changes and versioning. - Mark jaspr and jaspr_lints as unreleased patches. - Adjust jaspr_serverpod to indicate an unreleased minor version with a bump to serverpod 2.3.0.
- Revert changes to import retrieval process to maintain compatibility with analyzer ^6.5.0 - compilationUnit.libraryImports requires analyzer >=6.10.0 which is above our current constraint
CI automatically manages version numbers, reverting manual version change.
Hi @schultek Kilian melos analyze is not passing, can I re-commit with an improved version? |
- Keep the constraint at the minor level
- Fix GatherUsedImportedElementsVisitor instantiation - Remove unused import 'package:analyzer/src/error/imports_verifier.dart'
- Update import retrieval to use the library's compilation unit for better accuracy - Replace direct access to libraryImports and libraryExports with compilationUnit properties - Improve compatibility with the analyzer package by ensuring correct import processing - Remove lint warnings by properly handling nullable types and type casting
|
Its fine if the analysis is not passing for the other packages (builder and lints). You don't need to fix them. |
|
I've fixed the issues in main and pulled it into the pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
improve attribute name validation regex to support directives
Allow validation of directive-style attributes like ':class' and '@scroll.window' by updating the attribute name validation pattern.
Type of Change
Ready Checklist
the semantic_changelog format.
///).