-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added StyleSheet object to link external stylesheets #147
Conversation
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Package Version ReportThe following packages have been updated: |
Please run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 61.78% 69.17% +7.38%
==========================================
Files 102 31 -71
Lines 4106 1197 -2909
==========================================
- Hits 2537 828 -1709
+ Misses 1569 369 -1200 ☔ View full report in Codecov by Sentry. |
This is not necessary. You can already do this: Document(
head: [
link(rel: "stylesheet", href: "styles.css"),
],
body: App()
) |
should I make it a component instead, I think it's necessary, who wants to create a new link every time lol |
Also, one thing that confuses me is the separation of jaspr_core and components, even though they are both integrated in the same library. Is the plan to eventually migrate to strictly using BaseComponent's descendents? |
Then I would make it actually just a parameter on document, like directly a list of strings.
Tbh I don't like the api of BaseComponent right now and probably will just remove them at some point. Also Im not sure yet if I want to make a separate package for a set of ui components or keep it in the core package. |
Gotcha! Will try and implement. And yea my two cents are if you are keeping them then we should strictly build off the components. If you want to stick to low level dom stuff then spin it off onto a starter package for component libraries. also! I think you should personally double down on basic components like flutter, because as of right now it seems a bit unclear what Jaspr provides in the area of UI creation and design since I could probably just do dom manipulation with Dart:html... |
I'm going to close this as there hasn't been any activity. |
title
Description
Added StyleSheet object to link external stylesheets.
Type of Change
Ready Checklist
the semantic_changelog format.
///
).If you need help, consider asking for advice on the #contribute channel on Discord.