Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autounit #146

Merged
merged 7 commits into from
Jan 19, 2024
Merged

Autounit #146

merged 7 commits into from
Jan 19, 2024

Conversation

cybertheory
Copy link
Contributor

@cybertheory cybertheory commented Jan 6, 2024

Description

Added the 'auto' unit to jaspr package in the ui/style/properties/unit.dart

Type of Change

  • ❌ Breaking change
  • ✨ New feature or improvement
  • 🛠️ Bug fix
  • 🧹 Code refactor
  • 📝 Documentation
  • 🗑️ Chore

Ready Checklist

  • I've read the Contribution Guide.
  • In case this PR changes one of the core packages, I've modified the respective CHANGELOG.md file using
    the semantic_changelog format.
  • I updated/added relevant documentation (doc comments with ///).
  • I added myself to the AUTHORS file (optional, if you want to).

If you need help, consider asking for advice on the #contribute channel on Discord.

@cybertheory cybertheory requested a review from schultek as a code owner January 6, 2024 03:46
Copy link

docs-page bot commented Jan 6, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/schultek/jaspr~146

Documentation is deployed and generated using docs.page.

Copy link

github-actions bot commented Jan 6, 2024

Package Version Report

The following packages have been updated:
jaspr : 0.9.3 -> 0.10.0
jaspr_builder : 0.9.3 -> 0.10.0
jaspr_cli : 0.9.3 -> 0.10.0
jaspr_flutter_embed : 0.1.4 -> 0.1.5
jaspr_riverpod : 0.3.8 -> 0.3.9
jaspr_router : 0.3.0 -> 0.3.1
jaspr_test : 0.9.3 -> 0.10.0

Copy link
Owner

@schultek schultek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM and thanks for the PR. Just a nitpick.

packages/jaspr/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (685a9c3) 61.10% compared to head (b41aeb9) 61.05%.

Files Patch % Lines
...kages/jaspr/lib/src/ui/styles/properties/unit.dart 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   61.10%   61.05%   -0.06%     
==========================================
  Files          98       98              
  Lines        4062     4067       +5     
==========================================
+ Hits         2482     2483       +1     
- Misses       1580     1584       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schultek
Copy link
Owner

I updated the things I needed to merge. Thanks for the contribution 💙

@schultek schultek merged commit 651374d into schultek:main Jan 19, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants