Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create jaspr_lints package #133

Merged
merged 23 commits into from
Sep 12, 2024
Merged

Conversation

fusion44
Copy link
Contributor

@fusion44 fusion44 commented Nov 1, 2023

Description

As outlined in #132 I want to editing experience for Jaspr to be similar to what Flutter provides. This PR implements the initial version.

Type of Change

  • ✨ New feature or improvement
  • 📝 Documentation

fixes #132

Copy link

github-actions bot commented Nov 1, 2023

Package Version Report

The following packages have been updated:
jaspr : 0.15.0 -> 0.16.0
jaspr_builder : 0.15.0 -> 0.16.0
jaspr_cli : 0.15.0 -> 0.16.0
jaspr_flutter_embed : 0.3.4 -> 0.3.5
jaspr_riverpod : 0.3.14 -> 0.3.15
jaspr_router : 0.5.1 -> 0.5.2
jaspr_serverpod : 0.3.3 -> 0.3.4
jaspr_test : 0.15.0 -> 0.16.0

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.89%. Comparing base (2981999) to head (fea98d2).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   74.89%   74.89%           
=======================================
  Files         121      121           
  Lines        5203     5203           
=======================================
  Hits         3897     3897           
  Misses       1306     1306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schultek
Copy link
Owner

@fusion44 How is it going? I'd really love to have this in the framework, this would greatly improve the developer experience. I'm happy to co-work on this, just want to know the current status.

@fusion44
Copy link
Contributor Author

I've got a lot of stuff to do, so I can't devote much time to it. But things should slow down a bit in the next few weeks. I intend to continue working on it.

@mjablecnik
Copy link
Contributor

@fusion44 Hello, what is state of this PR?

@fusion44
Copy link
Contributor Author

Hi,

Unfortunately I can't work on this right now. I have some other commitments I have to complete first. Sorry.

@schultek
Copy link
Owner

schultek commented Sep 3, 2024

I started looking into it and added some initial code assists. Lets collect some lints/assists in the issue and align on what should be included in the initial version.

@mjablecnik
Copy link
Contributor

@schultek I believe the most important features are:

  • Adding new components/widgets in the component/widget tree.
  • Removing components/widgets from the tree.
  • Creating new components (stateless, stateful, and inherited).

When I look into the code, I can see these features are already in place.
If everything works and you don’t plan to add any other features at the moment, we can merge it since these three are crucial for a great development experience.

During future development, we can add additional features as needed. Alternatively, you could create a very simple tutorial on how to create and add new lint/assist features to Jaspr. This way, anyone can add new lint/assist features in the future as needed.

@schultek
Copy link
Owner

schultek commented Sep 9, 2024

I have mainly added the code assists. I will spend a bit more time on adding some lints.

@schultek schultek marked this pull request as ready for review September 11, 2024 21:53
@schultek schultek self-requested a review as a code owner September 11, 2024 21:53
Copy link
Contributor

@mjablecnik mjablecnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good, but I am missing maybe some short comments with description about assists what exactly does and I found some duplicity code or some small bugs.

docs/get_started/linting.mdx Outdated Show resolved Hide resolved
packages/jaspr_lints/README.md Show resolved Hide resolved
packages/jaspr_lints/lib/src/assists/component_assist.dart Outdated Show resolved Hide resolved
packages/jaspr_lints/lib/src/assists/tree_assist.dart Outdated Show resolved Hide resolved
packages/jaspr_lints/lib/src/assists/tree_assist.dart Outdated Show resolved Hide resolved
packages/jaspr_lints/pubspec.yaml Outdated Show resolved Hide resolved
packages/jaspr_lints/pubspec.yaml Outdated Show resolved Hide resolved
@schultek schultek changed the title [draft] Initial version of the Dart Analyzer plugin [#132] Create jaspr_lints package Sep 12, 2024
@schultek schultek requested a review from mjablecnik September 12, 2024 07:31
Copy link
Contributor

@mjablecnik mjablecnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found only some things with code formatting..

@mjablecnik
Copy link
Contributor

@schultek
Exists something how can I mark review comment as resolved?

I do not see any button to mark it as resolved and hide it:

Screenshot 2024-09-12 at 11 14 34

@schultek
Copy link
Owner

schultek commented Sep 12, 2024

@schultek Exists something how can I mark review comment as resolved?

I do not see any button to mark it as resolved and hide it:

Strange I have that button

@mjablecnik
Copy link
Contributor

@schultek Exists something how can I mark review comment as resolved?
I do not see any button to mark it as resolved and hide it:

Strange I have that button

Maybe I do not have some permission?

@schultek
Copy link
Owner

Sadly I cannot set specific permissions since this is a personal repo.

@schultek schultek enabled auto-merge September 12, 2024 14:16
@schultek schultek merged commit 5d8dddb into schultek:main Sep 12, 2024
11 checks passed
@fusion44 fusion44 deleted the feat/analyzer_plugin branch September 12, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Jaspr Dart Analyzer Plugin
3 participants