-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create jaspr_lints package #133
Conversation
Package Version ReportThe following packages have been updated: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
=======================================
Coverage 74.89% 74.89%
=======================================
Files 121 121
Lines 5203 5203
=======================================
Hits 3897 3897
Misses 1306 1306 ☔ View full report in Codecov by Sentry. |
@fusion44 How is it going? I'd really love to have this in the framework, this would greatly improve the developer experience. I'm happy to co-work on this, just want to know the current status. |
I've got a lot of stuff to do, so I can't devote much time to it. But things should slow down a bit in the next few weeks. I intend to continue working on it. |
@fusion44 Hello, what is state of this PR? |
Hi, Unfortunately I can't work on this right now. I have some other commitments I have to complete first. Sorry. |
I started looking into it and added some initial code assists. Lets collect some lints/assists in the issue and align on what should be included in the initial version. |
@schultek I believe the most important features are:
When I look into the code, I can see these features are already in place. During future development, we can add additional features as needed. Alternatively, you could create a very simple tutorial on how to create and add new lint/assist features to Jaspr. This way, anyone can add new lint/assist features in the future as needed. |
I have mainly added the code assists. I will spend a bit more time on adding some lints. |
# Conflicts: # docs.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is good, but I am missing maybe some short comments with description about assists what exactly does and I found some duplicity code or some small bugs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found only some things with code formatting..
@schultek I do not see any button to mark it as resolved and hide it: |
Strange I have that button |
Maybe I do not have some permission? |
Sadly I cannot set specific permissions since this is a personal repo. |
Description
As outlined in #132 I want to editing experience for Jaspr to be similar to what Flutter provides. This PR implements the initial version.
Type of Change
fixes #132