promote jaspr_web_compilers to non experimental

schultek · Jan 9, 2024 · 2d4d274 · 2d4d274
1 parent 1a0192b
commit 2d4d274
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 7 deletions.
diff --git a/modules/build b/modules/build
diff --git a/packages/jaspr/CHANGELOG.md b/packages/jaspr/CHANGELOG.md
@@ -1,3 +1,9 @@
+## Unreleased minor
+
+- Promoted `jaspr_web_compilers` to non-experimental status and changed cli command `jaspr create --experimental-web-compilers` 
+  to `jaspr create --jaspr-web-compilers`
+- Fixed error on windows when running `jaspr build`.
+
 ## 0.9.3
 
 - Fixed `melos format` on Windows.

diff --git a/packages/jaspr_cli/lib/src/commands/create_command.dart b/packages/jaspr_cli/lib/src/commands/create_command.dart
@@ -23,10 +23,9 @@ class CreateCommand extends BaseCommand {
       allowedHelp: templateDescriptionByName,
     );
     argParser.addFlag(
-      'experimental-web-compilers',
+      'jaspr-web-compilers',
       abbr: 'c',
-      help:
-          'Use jaspr web compilers (experimental)? This enables the use of flutter web plugins and direct flutter embedding.',
+      help: 'Uses jaspr_web_compilers. This enables the use of flutter web plugins and direct flutter embedding.',
       defaultsTo: null,
     );
   }
@@ -76,10 +75,11 @@ class CreateCommand extends BaseCommand {
 
     var template = templatesByName[templateName]!;
 
-    var useJasprCompilers = argResults!['experimental-web-compilers'] as bool?;
+    var useJasprCompilers = argResults!['jaspr-web-compilers'] as bool?;
     useJasprCompilers ??= logger.logger.confirm(
-        'Use jaspr web compilers (experimental)? This enables the use of flutter web plugins and direct flutter embedding.',
-        defaultValue: true);
+      'Use jaspr_web_compilers? This enables the use of flutter web plugins and direct flutter embedding.',
+      defaultValue: false,
+    );
 
     var progress = logger.logger.progress('Bootstrapping');
     var generator = await MasonGenerator.fromBundle(template);

diff --git a/packages/jaspr_cli/lib/src/helpers/flutter_helpers.dart b/packages/jaspr_cli/lib/src/helpers/flutter_helpers.dart
@@ -16,6 +16,7 @@ mixin FlutterHelper on BaseCommand {
     var flutterProcess = await Process.start(
       'flutter',
       ['run', '--device-id=web-server', '-t', '.dart_tool/jaspr/flutter_target.dart', '--web-port=5678'],
+      runInShell: true,
     );
 
     unawaited(watchProcess('flutter run', flutterProcess, tag: Tag.flutter, hide: (_) => !verbose));
@@ -29,6 +30,7 @@ mixin FlutterHelper on BaseCommand {
     var flutterProcess = await Process.start(
       'flutter',
       ['build', 'web', '-t', '.dart_tool/jaspr/flutter_target.dart', '--output=build/flutter'],
+      runInShell: true,
     );
 
     var target = useSSR ? 'build/jaspr/web' : 'build/jaspr';
+2 −2		jaspr_web_compilers/lib/src/common.dart
+1 −1		jaspr_web_compilers/pubspec.yaml