-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel commands #42
base: master
Are you sure you want to change the base?
Conversation
I didn't think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start. I'm a little wary of the command syntax though, as well as the Template type in general. Actually I think it's fine.
After you address the requested changes (using mapConcurrently
and unlines
) I'll check out the code and play around with it.
Thank you! Good work!
Thanks for the feedback! I fixed the things you mentioned. Before merging I'd like to do some renaming and possibly introduce some type aliases. But before doing that I'd be happy to see the code working correctly |
@schell sorry for bothering you, did you have the chance to play a bit with the code? |
Sorry @marcosh - I've been in the middle of a move. |
don't worry, I just feared you missed my previous message. No hurry |
closes #41
@schell I created a first draft of the functionality, possibly to get a first feedback from you.
I wanted also to ask you the following question: currently, when I try to run commands in parallel, the whole
sos
process goes to background. Is this the default behaviour forconcurrently
? Is there an easy way to keep everything in the foreground?