Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sync command to work in discord.py 2.4 #235

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

pythonmcpi
Copy link
Contributor

@pythonmcpi pythonmcpi commented Jun 14, 2024

Rationale

discord.py 2.4 updates the get_translated_payload and to_dict method signatures for application commands, making the CommandTree a required parameter.

Summary of changes made

Support the new function signatures without breaking backwards compatibility with discord.py <= 2.3

Supersedes #230

Checklist

  • This PR changes the jishaku module/cog codebase
    • These changes add new functionality to the module/cog
    • These changes fix an issue or bug in the module/cog
    • I have tested that these changes work on a production bot codebase
    • I have tested these changes against the CI/CD test suite
    • I have updated the documentation to reflect these changes
  • This PR changes the CI/CD test suite
    • I have tested my suite changes are well-formed (all tests can be discovered)
    • These changes adjust existing test cases
    • These changes add new test cases
  • This PR changes prose (such as the documentation, README or other Markdown/RST documents)
    • I have proofread my changes for grammar and spelling issues
    • I have tested that any changes regarding Markdown/RST syntax result in a well formed document

@JDJGInc
Copy link

JDJGInc commented Jun 24, 2024

as discord.py version 2.4 released recently this can be merged as confirmed.

@JDJGInc
Copy link

JDJGInc commented Jun 24, 2024

and if this gets merged

pr 230 can be closed too.

@scarletcafe scarletcafe merged commit 4408b2a into scarletcafe:master Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants