Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Postgres #116

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Add Postgres #116

merged 6 commits into from
Mar 14, 2024

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Nov 26, 2023 •
edited
Loading

Description

Support PostgreSQL for ScalarDB tests

Related issues and/or PRs

#113

Changes made

  • Implemented DbExtension PostgreSQL
  • Coordinated nemesis names

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

Provide any additional information or notes that may be relevant to the reviewers or stakeholders.

@yito88 yito88 force-pushed the feature/add-postgres branch 2 times, most recently from 11ae425 to d98c703 Compare December 16, 2023 20:57
@yito88 yito88 force-pushed the feature/add-postgres branch from 3a6a860 to cd8d3b5 Compare March 3, 2024 19:37
@yito88 yito88 marked this pull request as ready for review March 3, 2024 19:43
@yito88 yito88 requested review from brfrn169 and feeblefakie March 3, 2024 19:43
brfrn169
brfrn169 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

feeblefakie
feeblefakie approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! (Sorry for the late review.)

@feeblefakie feeblefakie merged commit e123b66 into master Mar 14, 2024
3 checks passed
@feeblefakie feeblefakie deleted the feature/add-postgres branch March 14, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feeblefakie feeblefakie feeblefakie approved these changes

@brfrn169 brfrn169 brfrn169 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yito88 @brfrn169 @feeblefakie