Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.13 #87

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Scala 2.13 #87

merged 4 commits into from
Sep 19, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Sep 9, 2023

In preparation for scalableminds/webknossos#7327

  • resource management with Using
  • flatMap in iterator? (needed new liftweb version)
  • test with wk locally

@fm3 fm3 self-assigned this Sep 9, 2023
@fm3 fm3 changed the title WIP: Scala 2.13 Scala 2.13 Sep 18, 2023
@fm3 fm3 marked this pull request as ready for review September 18, 2023 11:37
@fm3 fm3 requested a review from frcroth September 18, 2023 11:38
@@ -55,13 +55,12 @@ pomExtra := (
)

libraryDependencies ++= Seq(
"com.google.guava" % "guava" % "21.0",
"com.jsuereth" %% "scala-arm" % "2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was that and why isn't it needed anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic Resource Management. Scala 2.13 has that in the core library (the whole Releasable/Using stuff), compare jsuereth/scala-arm#79

@fm3 fm3 merged commit d3ae27e into master Sep 19, 2023
14 checks passed
@fm3 fm3 deleted the scala213 branch September 19, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants