Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc variable name in Lens exercises #142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukeknxt
Copy link

@lukeknxt lukeknxt commented Aug 28, 2021

The guiding comments don't align with the actual code.

For example one sees

import monocle.macros.GenLens
val strNumber = GenLens[Address](_.strNumber)

val address = Address(10, "High Street")

And immediately after

streetNumber.get(address) should be(_)

streetNumber used instead of strNumber in the Address case class for consistency too.

This has been opened twice - #7 and #8, but they are either not approved or approved and forgotten about it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant