fixed skipping events in BatchList

sc0ty · Jul 23, 2020 · 967410b · 967410b
1 parent 2f6625a
commit 967410b
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/subsync/gui/components/batchlist/batchlist.py b/subsync/gui/components/batchlist/batchlist.py
@@ -487,7 +487,6 @@ def dragSelection(self, src=None):
     @update_lock
     def onLeftDown(self, event):
         self.clearSelection()
-        event.Skip()
 
     @update_lock
     def onResize(self, event):
@@ -569,7 +568,6 @@ def onMenuChannelsClick(self, event, cell=None):
             with ChannelsWin(self, channelIds=ids) as dlg:
                 if dlg.ShowModal() == wx.ID_OK:
                     self.updateSelectedInputs(channels=dlg.GetValue())
-        event.Skip()
 
     @error_dlg
     @update_lock

diff --git a/subsync/gui/components/batchlist/cell.py b/subsync/gui/components/batchlist/cell.py
@@ -66,15 +66,15 @@ def onLeftDown(self, event):
                 self.parent.setPickedCell(self)
         else:
             self.parent.clearSelection()
-        event.Skip()
 
     def onLeftUp(self, event):
         if self.visible and not event.ControlDown() and not event.ShiftDown() \
-                    and not event.GetId() == self.m_bitmapIcon.GetId():
-                self.parent.clearSelection(exclude=[ self ])
-                self.select(True)
-                self.parent.setPickedCell(self)
-        event.Skip()
+                and not event.GetId() == self.m_bitmapIcon.GetId():
+            self.parent.clearSelection(exclude=[ self ])
+            self.select(True)
+            self.parent.setPickedCell(self)
+        else:
+            event.Skip()
 
     def onLeftDClick(self, event):
         event.Skip()
diff --git a/subsync/gui/components/batchlist/inputcell.py b/subsync/gui/components/batchlist/inputcell.py
@@ -100,7 +100,8 @@ def onMouseMove(self, event):
     def onLeftDClick(self, event):
         if self.item is not None:
             self.showPropsWin()
-        event.Skip()
+        else:
+            event.Skip()
 
     def showPropsWin(self):
         self.parent.clearSelection(exclude=[ self ])

diff --git a/subsync/gui/components/batchlist/outputcell.py b/subsync/gui/components/batchlist/outputcell.py
@@ -61,7 +61,8 @@ def showPropsWin(self):
     def onLeftDClick(self, event):
         if self.visible:
             self.showPropsWin()
-        event.Skip()
+        else:
+            event.Skip()
 
 
 class OutputSyncCell(BaseCell):