Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change installation process instead of requiring navigating / deleting files yourself #662

Open
wants to merge 3 commits into
base: v1.x
Choose a base branch
from

Conversation

Naleksuh
Copy link

@Naleksuh Naleksuh commented Apr 9, 2020

Description

Motivation and Context

This change is not required, but makes installing much easier and less reliant on manual control. (To prevent malicious users from completing the installation, the config.php file will not be written automatically, which is a security issue on its own, but will be handled in a later PR).

How Has This Been Tested?

I have tested them through independent deleting of directories and Header Locations to point to the install folder. They were not used under SourceBans thus far, but is planned.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@Naleksuh
Copy link
Author

Naleksuh commented Apr 9, 2020

In addition, GitHub automatically changed the formatting codec of system-functions.php, so it will show as though the entire document has been deleted and readded. In reality, the only change there is adding the function to delete folders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant