-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/34127 #3
base: trunk
Are you sure you want to change the base?
Fix/34127 #3
Conversation
Hi @dpanta94, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think only missing the changelog and if we could clear the commits from other contributors would be great
Got it, the other commits are because our repo is outdated, need to re-updated it |
Just refetched the trunk branch here, a merge could resolve it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We likely need to rebase here
.gitattributes
Outdated
@@ -0,0 +1,15 @@ | |||
* text=auto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to exclude these files from being in the commits
@@ -0,0 +1,4 @@ | |||
Significance: patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are including more than 1 patch here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a whitespace change related to the gitattributes
@alexiglesias31 if already accepted in woo lets close this 😄 |
Submission Review Guidelines:
Changes proposed in this Pull Request:
Prevent to call to login function if the user is already logged in.
Closes woocommerce#34127.
How to test the changes in this Pull Request: