Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/34127 #3

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from
Open

Fix/34127 #3

wants to merge 6 commits into from

Conversation

alexiglesias31
Copy link
Collaborator

Submission Review Guidelines:

Changes proposed in this Pull Request:

Prevent to call to login function if the user is already logged in.

Closes woocommerce#34127.

How to test the changes in this Pull Request:

  1. New user is created during checkout.
  2. User gets a link in email to set their password.
  3. User follows link and sets new password.
  4. User is taken to the login page with message “Your password has been reset successfully.”
  5. User enters email and password, clicks “Login”. The login operation should be successful at the first try.

@github-actions
Copy link

Hi @dpanta94,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link

@dpanta94 dpanta94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only missing the changelog and if we could clear the commits from other contributors would be great

@alexiglesias31
Copy link
Collaborator Author

Got it, the other commits are because our repo is outdated, need to re-updated it

@dpanta94
Copy link

Just refetched the trunk branch here, a merge could resolve it

Copy link
Member

@msaggiorato msaggiorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We likely need to rebase here

.gitattributes Outdated
@@ -0,0 +1,15 @@
* text=auto
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to exclude these files from being in the commits

@@ -0,0 +1,4 @@
Significance: patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are including more than 1 patch here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a whitespace change related to the gitattributes

@dpanta94
Copy link

@alexiglesias31 if already accepted in woo lets close this 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First Login for New User Always Fails With No Error Messages
3 participants