Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fat binary Windows on Ruby 3.1 (x64-mingw-ucrt) #238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnnyshields
Copy link

@johnnyshields johnnyshields commented Jun 24, 2022

Fixes #237

As of Ruby 3.1, the Ruby Windows Installer is now releasing its platform as x64-mingw-ucrt. Refer to ruby/setup-ruby#193

Compare Ruby 3.0 vs. 3.1 on Windows:

ruby 3.0.0p0 (2020-12-25 revision 95aff21468) [x64-mingw32]
ruby 3.1.1p18 (2022-02-18 revision 53f5fc4236) [x64-mingw-ucrt]

This patch adds x64-mingw-ucrt to the cross-compilation, so that a fat binary will be created for x64-mingw-ucrt platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please rebuild native gems then release new gem version
1 participant