Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 378 #379

Merged
merged 9 commits into from
Oct 31, 2024
Merged

Issue 378 #379

merged 9 commits into from
Oct 31, 2024

Conversation

YuryShkoda
Copy link
Member

@YuryShkoda YuryShkoda commented Oct 31, 2024

Issue

Closes #378

Intent

  • Add /SASjsApi/session/{sessionId}/state API endpoint.

Implementation

  • Replaced multiple properties of the Session interface indicating session state with a single state property at api/src/types/Session.ts.
  • Refactored session-related code to apply updated Session interface.
  • Added GET /{sessionId}/state route to session router at api/src/routes/api/session.ts.
  • Added sessionIdValidation at api/src/utils/validation.ts.
  • Added sessionState method to SessionController at api/src/controllers/session.ts.

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • Reviewer is assigned.

api/src/types/Session.ts Outdated Show resolved Hide resolved
api/src/controllers/internal/processProgram.ts Outdated Show resolved Hide resolved
Copy link

@medjedovicm4gl medjedovicm4gl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have anything else to add

@YuryShkoda YuryShkoda merged commit d6e527e into main Oct 31, 2024
3 checks passed
@YuryShkoda YuryShkoda deleted the issue-378 branch October 31, 2024 12:51
Copy link

🎉 This PR is included in version 0.39.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add API endpoint to get session state
4 participants