Optimize DPO recipe - precomputing reference model log probabilites #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
Changelog
What are the changes made in this PR?
The primary purpose of this PR is to add support for precomputing reference log probabilities when using DPO. This would make the overall training faster by removing the redundant computation across epochs.
CustomPreferenceDataset
- This file is a modification of the Preference Dataset that allows the storage of the reference log probabilities along with the data. Every get-item call would return a dictionary of input_ids, labels and the reference model chosen and rejected log probabilities.padded_collate_dpo
- Modified this function to return the precomputed log probabilities too along with the inputs and labels.lora_dpo_distributed
- Added the support to precompute the reference log probabilities during data setup. For computing losses, the batch item can return the precomputed values saving compute. Implementation is inspired from the Hugging Face trl repository DPO implementation.Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install
)pytest tests
pytest tests -m integration_test
UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example