Using FormattedCheckpointFiles in configs... round 2 (pytorch#2167)

sarvamai · Dec 23, 2024 · 9457ef0 · 9457ef0
1 parent f17c3fc
commit 9457ef0
Show file tree

Hide file tree

Showing 13 changed files with 13 additions and 13 deletions.
diff --git a/recipes/configs/llama2/70B_lora.yaml b/recipes/configs/llama2/70B_lora.yaml
@@ -31,7 +31,7 @@ checkpointer:
   checkpoint_dir:  /tmp/Llama-2-70b-hf
   checkpoint_files:
     filename_format: pytorch_model-{}-of-{}.bin
-    max_filename: 00015
+    max_filename: "00015"
   recipe_checkpoint: null
   output_dir: ${output_dir}
   model_type: LLAMA2

diff --git a/recipes/configs/llama2/70B_qlora.yaml b/recipes/configs/llama2/70B_qlora.yaml
@@ -36,7 +36,7 @@ checkpointer:
   checkpoint_dir:  /tmp/Llama-2-70b-hf
   checkpoint_files:
     filename_format: pytorch_model-{}-of-{}.bin
-    max_filename: 00015
+    max_filename: "00015"
   recipe_checkpoint: null
   output_dir: ${output_dir}
   model_type: LLAMA2

diff --git a/recipes/configs/llama3/70B_full.yaml b/recipes/configs/llama3/70B_full.yaml
@@ -41,7 +41,7 @@ checkpointer:
   checkpoint_dir: /tmp/Meta-Llama-3-70B-Instruct
   checkpoint_files:
     filename_format: model-{}-of-{}.safetensors
-    max_filename: 00030
+    max_filename: "00030"
   recipe_checkpoint: null
   output_dir: ${output_dir}
   model_type: LLAMA3

diff --git a/recipes/configs/llama3/70B_lora.yaml b/recipes/configs/llama3/70B_lora.yaml
@@ -31,7 +31,7 @@ checkpointer:
   checkpoint_dir:  /tmp/Meta-Llama-3-70B-Instruct
   checkpoint_files:
     filename_format: model-{}-of-{}.safetensors
-    max_filename: 00030
+    max_filename: "00030"
   recipe_checkpoint: null
   output_dir: ${output_dir}
   model_type: LLAMA3

diff --git a/recipes/configs/llama3_1/70B_full.yaml b/recipes/configs/llama3_1/70B_full.yaml
@@ -40,7 +40,7 @@ checkpointer:
   checkpoint_dir: /tmp/Meta-Llama-3.1-70B-Instruct/
   checkpoint_files:
     filename_format: model-{}-of-{}.safetensors
-    max_filename: 00030
+    max_filename: "00030"
   recipe_checkpoint: null
   output_dir: ${output_dir}
   model_type: LLAMA3

diff --git a/recipes/configs/llama3_1/70B_lora.yaml b/recipes/configs/llama3_1/70B_lora.yaml
@@ -30,7 +30,7 @@ checkpointer:
   checkpoint_dir: /tmp/Meta-Llama-3.1-70B-Instruct/
   checkpoint_files:
     filename_format: model-{}-of-{}.safetensors
-    max_filename: 00030
+    max_filename: "00030"
   recipe_checkpoint: null
   output_dir: ${output_dir}
   model_type: LLAMA3

diff --git a/recipes/configs/llama3_3/70B_full.yaml b/recipes/configs/llama3_3/70B_full.yaml
@@ -40,7 +40,7 @@ checkpointer:
   checkpoint_dir: /tmp/Llama-3.3-70B-Instruct/
   checkpoint_files:
     filename_format: model-{}-of-{}.safetensors
-    max_filename: 00030
+    max_filename: "00030"
   recipe_checkpoint: null
   output_dir: ${output_dir}
   model_type: LLAMA3

diff --git a/recipes/configs/llama3_3/70B_lora.yaml b/recipes/configs/llama3_3/70B_lora.yaml
@@ -30,7 +30,7 @@ checkpointer:
   checkpoint_dir: /tmp/Llama-3.3-70B-Instruct/
   checkpoint_files:
     filename_format: model-{}-of-{}.safetensors
-    max_filename: 00030
+    max_filename: "00030"
   recipe_checkpoint: null
   output_dir: ${output_dir}
   model_type: LLAMA3

diff --git a/recipes/configs/llama3_3/70B_qlora.yaml b/recipes/configs/llama3_3/70B_qlora.yaml
@@ -30,7 +30,7 @@ checkpointer:
   checkpoint_dir: /tmp/Llama-3.3-70B-Instruct/
   checkpoint_files:
     filename_format: model-{}-of-{}.safetensors
-    max_filename: 00030
+    max_filename: "00030"
   recipe_checkpoint: null
   output_dir: ${output_dir}
   model_type: LLAMA3

diff --git a/recipes/configs/qwen2_5/14B_lora_single_device.yaml b/recipes/configs/qwen2_5/14B_lora_single_device.yaml
@@ -39,7 +39,7 @@ checkpointer:
   checkpoint_dir: /tmp/Qwen2_5-14B-Instruct
   checkpoint_files:
     filename_format: model-{}-of-{}.safetensors
-    max_filename: 00008
+    max_filename: "00008"
   recipe_checkpoint: null
   output_dir: ${output_dir}
   model_type: QWEN2

diff --git a/recipes/configs/qwen2_5/32B_lora.yaml b/recipes/configs/qwen2_5/32B_lora.yaml
@@ -37,7 +37,7 @@ checkpointer:
   checkpoint_dir: /tmp/Qwen2_5-32B-Instruct
   checkpoint_files:
     filename_format: model-{}-of-{}.safetensors
-    max_filename: 00017
+    max_filename: "00017"
   recipe_checkpoint: null
   output_dir: ${output_dir}
   model_type: QWEN2

diff --git a/recipes/configs/qwen2_5/72B_lora.yaml b/recipes/configs/qwen2_5/72B_lora.yaml
@@ -37,7 +37,7 @@ checkpointer:
   checkpoint_dir: /tmp/Qwen2_5-72B-Instruct
   checkpoint_files:
     filename_format: model-{}-of-{}.safetensors
-    max_filename: 00037
+    max_filename: "00037"
   recipe_checkpoint: null
   output_dir: ${output_dir}
   model_type: QWEN2

diff --git a/torchtune/training/checkpointing/_utils.py b/torchtune/training/checkpointing/_utils.py
@@ -531,7 +531,7 @@ def validate_checkpoint_files(
     # e.g.
     # checkpoint_files:
     #   filename_format: model-{}-of-{}.safetensors
-    #   max_filename: 00191
+    #   max_filename: "00191"
     # becomes checkpoint_files = [model-00001-of-00191.safetensors, model-00002-of-00191,..]
     if not isinstance(checkpoint_files, List):
         # TODO: this can be a function instead of a class