Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support visit_seq for Deserialize #152

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

kemingy
Copy link
Contributor

@kemingy kemingy commented Sep 18, 2024

visit_seq is required if people want to use serde + faer with bincode.

See:

Basically, this PR only changed the position of MatrixOrVecDeserializer + MatrixOrVec and added the visit_seq method.

cargo +nightly fmt changed some code. Let me know if I need to revert these changes.

@sarah-quinones sarah-quinones merged commit 8afdba4 into sarah-quinones:main Sep 29, 2024
5 of 7 checks passed
@kemingy kemingy deleted the serde_seq branch October 3, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants