fix: spliceUrlParam remove encodeURIComponent

saqqdy · Aug 9, 2024 · f2fc704 · f2fc704
1 parent e7cdd1b
commit f2fc704
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Change logs
 
+## 2024.08.09 v5.20.0
+
+1. `spliceUrlParam` Breaking change: remove encodeURIComponent
+
 ## 2024.05.30 v5.19.2
 
 1. upgrade `await-to-done`, fix types

diff --git a/README.md b/README.md
@@ -1533,6 +1533,8 @@ declare function parseUrlParam(url: string, covert?: boolean): Record<string, un
 
 Splice URL parameters (single layer only)
 
+> v5.20.0 Breaking change: remove encodeURIComponent
+
 - Since: `5.3.0`
 
 - Arguments:
@@ -1548,8 +1550,8 @@ Splice URL parameters (single layer only)
 - Example:
 
 ```ts
-spliceUrlParam({ key1: '100', key2: 'true', key3: 'null', key4: 'undefined', key4: '测试' })
-// ?key1=100&key2=true&key3=null&key4=undefined&key5=%E6%B5%8B%E8%AF%95
+spliceUrlParam({ key1: '100', key2: 'true', key3: 'null', key4: 'undefined', key5: '测试' })
+// ?key1=100&key2=true&key3=null&key4=undefined&key5=测试
 
 spliceUrlParam({ key1: '100', key2: 'true', key3: 'null', key4: 'undefined' }, true)
 // ?key1=100&key2=true&key3=&key4=

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
 	"name": "js-cool",
 	"description": "Collection of common JavaScript / TypeScript utilities",
-	"version": "5.19.2",
+	"version": "5.20.0",
 	"packageManager": "[email protected]",
 	"main": "dist/index.cjs.js",
 	"module": "dist/index.esm-bundler.js",

diff --git a/src/spliceUrlParam.ts b/src/spliceUrlParam.ts
@@ -3,8 +3,8 @@
  *
  * @example
  * ```js
- * spliceUrlParam('\{"key1":"100","key2":"true","key3":"null","key4":"undefined","key4":"测试"\}')
- * // ?key1=100&key2=true&key3=null&key4=undefined&key5=%E6%B5%8B%E8%AF%95
+ * spliceUrlParam('\{"key1":"100","key2":"true","key3":"null","key4":"undefined","key5":"测试"\}')
+ * // ?key1=100&key2=true&key3=null&key4=undefined&key5=测试
  *
  * spliceUrlParam('\{"key1":"100","key2":"true","key3":"null","key4":"undefined"\}', true)
  * // ?key1=100&key2=true&key3=&key4=
@@ -32,9 +32,7 @@ function spliceUrlParam<T extends Record<string, unknown>>(
 	const result: string[] = []
 	for (key in params) {
 		typeof key === 'string' &&
-			result.push(
-				`${key}=${encodeURIComponent('' + (covert ? params[key] ?? '' : params[key]))}`
-			)
+			result.push(`${key}=${'' + (covert ? params[key] ?? '' : params[key])}`)
 	}
 
 	if (withQuestionsMark) return '?' + result.join('&')