Add dry run test #16
Merged
Add dry run test #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one job in the matrix of jobs fails, we still want to be able to see the results from the other jobs.
jmgate
force-pushed
the
add-dry-run-test
branch
2 times, most recently
from
1b4fe58 to
fadc619
Compare
This package was originally developed for Python 3.6, before `functools.cached_property` was introduced. That should be a drop-in replacement for the home-grown `lazy_property`, though, so now that we just support Python 3.8+, we should use it instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Task
Commits
ci: Don't fail fast (0d3a5e3)
If one job in the matrix of jobs fails, we still want to be able to see the results from the other jobs.
refactor: Use functools.cached_property instead (3d91282)
This package was originally developed for Python 3.6, before
functools.cached_propertywas introduced. That should be a drop-in replacement for the home-grownlazy_property, though, so now that we just support Python 3.8+, we should use it instead.test: Add coverage configuration (27bc6d6)
test: Cover
run()in dry-run mode (c44d6ff)Motivation
Just wanting complete unit test coverage for safety's sake.