refactor(cpp): abstract out a BaseModel class for API clarity #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e explicit (not enforced yet)
* ci: add executable to release workflow * ci: modify semantic-release pr requests to choose between release and chore --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: David Hart <[email protected]>
build: update to create a standalone executable (sandialabs#66) * ci: add executable to release workflow * ci: modify semantic-release pr requests to choose between release and chore * docs: update readme to show standalone version is available * ci: create reusable testing workflow --------- Signed-off-by: David Hart <[email protected]> Co-authored-by: David Hart <[email protected]>
dbhart
added
github_actions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #71 +/- ##
==========================================
Coverage ? 88.05%
==========================================
Files ? 9
Lines ? 2001
Branches ? 0
==========================================
Hits ? 1762
Misses ? 239
Partials ? 0
|
dbhart
added a commit
that referenced
this pull request
Oct 23, 2024
* build: update to create a standalone executable (#66) * ci: add executable to release workflow * ci: modify semantic-release pr requests to choose between release and chore * docs: update readme to show standalone version is available Signed-off-by: David Hart <[email protected]> * ci: create reusable testing workflow Signed-off-by: David Hart <[email protected]> --------- Signed-off-by: David Hart <[email protected]> * refactor(cpp): abstract out a BaseModel class for API clarity (#71) * refactor: change the way logging is done, make output directories more explicit (not enforced yet) * refactor: modify logging output formats * refactor: move certain elements out of Model into a BaseModel * ci: Check output of a continuous release process * ci: modify semantic-release pr requests to choose between release and chore * refactor(version): move location of version number to avoid circular imports * refactor(test): fix test to match refactor of license and copyright text names * ci(test): Test using re-usable workflow for testing * ci(test): update test workflows to use same reusable workflow underneath * ci(test): create separate tests for each of the OSes * ci(testsuite): change titles of os-specific workflows for brevity * release: 1.0.3 Automatically generated by python-semantic-release --------- Signed-off-by: David Hart <[email protected]> Co-authored-by: David Hart <[email protected]> Co-authored-by: github-actions <[email protected]>
dbhart
added a commit
that referenced
this pull request
Oct 23, 2024
* chore: Merge non-code changes into main (#69) build: update to create a standalone executable (#66) * ci: add executable to release workflow * ci: modify semantic-release pr requests to choose between release and chore * docs: update readme to show standalone version is available * ci: create reusable testing workflow --------- Signed-off-by: David Hart <[email protected]> Co-authored-by: David Hart <[email protected]> * release: Merge into main and create tag as v1.0.3 (#72) * build: update to create a standalone executable (#66) * ci: add executable to release workflow * ci: modify semantic-release pr requests to choose between release and chore * docs: update readme to show standalone version is available Signed-off-by: David Hart <[email protected]> * ci: create reusable testing workflow Signed-off-by: David Hart <[email protected]> --------- Signed-off-by: David Hart <[email protected]> * refactor(cpp): abstract out a BaseModel class for API clarity (#71) * refactor: change the way logging is done, make output directories more explicit (not enforced yet) * refactor: modify logging output formats * refactor: move certain elements out of Model into a BaseModel * ci: Check output of a continuous release process * ci: modify semantic-release pr requests to choose between release and chore * refactor(version): move location of version number to avoid circular imports * refactor(test): fix test to match refactor of license and copyright text names * ci(test): Test using re-usable workflow for testing * ci(test): update test workflows to use same reusable workflow underneath * ci(test): create separate tests for each of the OSes * ci(testsuite): change titles of os-specific workflows for brevity * release: 1.0.3 Automatically generated by python-semantic-release --------- Signed-off-by: David Hart <[email protected]> Co-authored-by: David Hart <[email protected]> Co-authored-by: github-actions <[email protected]> --------- Signed-off-by: David Hart <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <[email protected]>
dbhart
added a commit
to dbhart/sansmic
that referenced
this pull request
Oct 29, 2024
* release: Merge into main and create tag as v1.0.3 (sandialabs#72) * build: update to create a standalone executable (sandialabs#66) * ci: add executable to release workflow * ci: modify semantic-release pr requests to choose between release and chore * docs: update readme to show standalone version is available Signed-off-by: David Hart <[email protected]> * ci: create reusable testing workflow Signed-off-by: David Hart <[email protected]> --------- Signed-off-by: David Hart <[email protected]> * refactor(cpp): abstract out a BaseModel class for API clarity (sandialabs#71) * refactor: change the way logging is done, make output directories more explicit (not enforced yet) * refactor: modify logging output formats * refactor: move certain elements out of Model into a BaseModel * ci: Check output of a continuous release process * ci: modify semantic-release pr requests to choose between release and chore * refactor(version): move location of version number to avoid circular imports * refactor(test): fix test to match refactor of license and copyright text names * ci(test): Test using re-usable workflow for testing * ci(test): update test workflows to use same reusable workflow underneath * ci(test): create separate tests for each of the OSes * ci(testsuite): change titles of os-specific workflows for brevity * release: 1.0.3 Automatically generated by python-semantic-release --------- Signed-off-by: David Hart <[email protected]> Co-authored-by: David Hart <[email protected]> Co-authored-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update provides an abstraction to the sansmic::Model class that is the sansmic::BaseModel class. This is primarily to cut down on the linter issues with having too many member functions and attributes, but also to make it clear which parts are more for API/Communication with the Python and which are internal numerical modeling functions.
This also contains updates to some of the workflows for testing clarity.