Screen

[CFGrote]

Solves #111

[buzmakov]

Looks fine for me.

@samoylv Could you review this code?

[buzmakov]

@CFGrote now we will have 2 folders for test: tests and unittest ?
Could we merge them in one folder?

[CFGrote]

we could, but separating unittests from functional tests also has its benefits. do the tests in tests/ actually work? i tried once and got heaps of exceptions, never tried again. tests in unittest/ use unittest framework.

…

On 03/29/2017 04:46 PM, Alexey Buzmakov wrote: @CFGrote <https://github.com/CFGrote> now we will have 2 folders for test: tests and unittest ? Could we merge them in one folder? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#112 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOwoR1_O6x2eeU3pyIszVvUikx5aeUwdks5rqm67gaJpZM4MtEH_>.

-- Dr. Carsten Fortmann-Grote Scientist for Scientific Simulations / Wissenschaftler fuer wissenschaftliche Simulationen European XFEL GmbH Holzkoppel 4 22869 Schenefeld Germany Phone: +49 (0)40 8998-5603 Fax: +49 (0)40 8998-1905 Email: [email protected] Web: www.xfel.eu Managing Directors: Prof. Dr. Robert Feidenhans'l, Dr. Claudia Burger Registered as European X-Ray Free-Electron Laser Facility GmbH at Amtsgericht Hamburg, HRB 111165

[buzmakov]

1. I agree to keep unittests and test in separate folders.

2. Tests in wpg/tests should work fine.
   I run them when build docker container and check that results identical to Oleg's SRW results.
   cd WPG; python -m pytest .
   Now tests also run our tutorial notebooks and check that there are no errors in tutorials (so it can take up to 20 min).
   The develop branch has small set of tests, and openmp branch has full set of tests (to be sure that openmp not brake the world)

[samoylv]

ok, the code and the comparison results look fine with me. Have no time to run it by myself, but as you did the tests, we can merge.
BTW, I was not able to recognize from observation how the stepwise can be used. Shall we add an option to prop module for stepwise propagation?

[CFGrote]

here's how i use it: #! /usr/bin/env python2.7 import os,sys import exfel_spb_kb_beamline as bl import prop pulse_file = '5keV_9fs_2014_slice20_T50_nxy100_0000001.h5' out_file = 'ap_kb.h5' def step(): prop.propagate_s2e.stepwise(pulse_file, bl.get_beamline) if __name__ == "__main__": step() in simex i would make a new calculator or add an option to XFELPhotonPropagator that triggers usage of stepwise() instead of propagate(). carsten

…

On 03/30/2017 08:56 AM, samoylv wrote: ok, the code and the comparison results look fine with me. Have no time to run it by myself, but as you did the tests, we can merge. BTW, I was not able to recognize from observation how the stepwise can be used. Shall we add an option to prop module for stepwise propagation? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#112 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOwoRymjPD98aIsNOjUQG6P0eWJ0RG-bks5rq1IwgaJpZM4MtEH_>.

-- Dr. Carsten Fortmann-Grote Scientist for Scientific Simulations / Wissenschaftler fuer wissenschaftliche Simulationen European XFEL GmbH Holzkoppel 4 22869 Schenefeld Germany Phone: +49 (0)40 8998-5603 Fax: +49 (0)40 8998-1905 Email: [email protected] Web: www.xfel.eu Managing Directors: Prof. Dr. Robert Feidenhans'l, Dr. Claudia Burger Registered as European X-Ray Free-Electron Laser Facility GmbH at Amtsgericht Hamburg, HRB 111165

[CFGrote]

thanks!

…

On 03/30/2017 04:11 PM, Alexey Buzmakov wrote: Merged #112 <#112>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#112 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOwoR2dE2r1RHT0gvivXx0XSRo4WLXMyks5rq7f9gaJpZM4MtEH_>.

-- Dr. Carsten Fortmann-Grote Scientist for Scientific Simulations / Wissenschaftler fuer wissenschaftliche Simulationen European XFEL GmbH Holzkoppel 4 22869 Schenefeld Germany Phone: +49 (0)40 8998-5603 Fax: +49 (0)40 8998-1905 Email: [email protected] Web: www.xfel.eu Managing Directors: Prof. Dr. Robert Feidenhans'l, Dr. Claudia Burger Registered as European X-Ray Free-Electron Laser Facility GmbH at Amtsgericht Hamburg, HRB 111165