Skip to content

Commit

Permalink
github: order some keys for consistency
Browse files Browse the repository at this point in the history
Re-order some top level keys under each job so that they're more
consistent. From top-to-bottom: strategy, needs, runs-on,
env, steps. Some keys are optional.

Signed-off-by: John Mulligan <[email protected]>
  • Loading branch information
phlogistonjohn authored and mergify[bot] committed Jul 19, 2023
1 parent aff2001 commit 8a631d9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/container-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ jobs:
run: make check-gitlint

build-server:
runs-on: ubuntu-latest
strategy:
matrix:
os: [centos, fedora, opensuse]
arch: [amd64]
runs-on: ubuntu-latest
env:
BUILDAH_FORMAT: oci
steps:
Expand Down Expand Up @@ -80,9 +80,9 @@ jobs:
matrix:
os: [centos, fedora, opensuse]
arch: [amd64]
runs-on: ubuntu-latest
env:
BUILDAH_FORMAT: oci
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: build the client image
Expand Down Expand Up @@ -137,11 +137,11 @@ jobs:
# Reminder: the nightly-server images consume nightly samba rpm builds
# it is not *just* an image that gets built nightly
build-nightly-server:
runs-on: ubuntu-latest
strategy:
matrix:
os: [centos, fedora]
arch: [amd64]
runs-on: ubuntu-latest
env:
BUILDAH_FORMAT: oci
steps:
Expand All @@ -156,11 +156,11 @@ jobs:
retention_days: 1

build-nightly-ad-server:
runs-on: ubuntu-latest
strategy:
matrix:
os: [centos, fedora]
arch: [amd64]
runs-on: ubuntu-latest
env:
BUILDAH_FORMAT: oci
steps:
Expand Down

0 comments on commit 8a631d9

Please sign in to comment.