Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] fix yumpkg for Python <3.8 #67152

Open
wants to merge 1 commit into
base: 3006.x
Choose a base branch
from

Conversation

hurzhurz
Copy link
Contributor

@hurzhurz hurzhurz commented Jan 15, 2025

What does this PR do?

The yumpkg module doesn't not work anymore with Ptyhon versions older than 3.8 because of the usage of the assignment/named expression.
This is a trivial change to fix it.

What issues does this PR fix or reference?

Fixes #67151

@dwoz
Copy link
Contributor

dwoz commented Jan 15, 2025

We do not support python lower than 3.10 in 3006.x.

@hurzhurz
Copy link
Contributor Author

We do not support python lower than 3.10 in 3006.x.

Yes, I understand that it is not officially supported for older python versions.
But it helps a lot that it still works (at least for the most part). Especially for salt-ssh.
And thankfully also the requirements files are kept up to date for python versions down to 3.7.

I guess this tiny change wouldn't harm to keep it working, like it did before 3006.9 ?
And as far as I can tell, this is also the only occurrence of the assignment expression := in 3006 so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants