[master] Don't block when evaluating requisites of parallel states #66956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
lkubb
force-pushed
the
parallel-require-fix
branch
from
4c7f0e0
to
9ce9dbd
Compare
lkubb
force-pushed
the
parallel-require-fix
branch
from
9ce9dbd
to
b65d8a1
Compare
3 tasks
twangboy
previously approved these changes
Oct 25, 2024
|
Sorry for dismissing the review, I noticed the patch introduced a regression when non-parallel states require parallel ones. |
twangboy
previously requested changes
Nov 6, 2024
|
There is a news fragment at https://github.com/saltstack/salt/pull/66956/files#diff-895ed1969c9b8dd072a1cdd582b61bb05de4311f862a52dedebff1edce889248 and an issue at #59959, which is referenced in the changelog entry. |
twangboy
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Evaluates requisites between parallel states less synchronously.
What issues does this PR fix or reference?
Fixes #59959
Previous Behavior
A state with unmet requisites marked as
parallelwould block state execution until all requisites were met, i.e. its requisites would be evaluated synchronously.New Behavior
Execution of a parallel state with unmet requisites is postponed, allowing other parallel states with met dependencies to be started immediately.
This does not implement complete parallelization of requisite checks. The stack of postponed parallel states is iterated over after each single state execution, meaning a non-parallel state in between causes parallel ones whose dependencies finish while it is executing to be started only after it has finished.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes