Fixed IP Blocks IT

[kdsalvy]

No description provided.

[waynew]

Still seeing

E       AssertionError: assert 'error' not in {'error': 'Error occurred while calling NSX-T API https://nsxt-hostname/ip/api/v1/pools/ip-blocks/. Please check logs for more details.'}

The other test failures should be sorted, so you should be able to merge the latest from the main branch into your PR (or rebase on main).

[waynew]

I think you should be able to see the project on the right-hand column - once you get this test passing, feel free to move this back to the backlog column 👍

[kdsalvy]

The test is passing for me, can you please use the config shared?

[waynew]

Note: When testing locally for a code review, ensure that your local repository does not contain any changes. If you're testing with local changes then you'll be testing something different than what others are testing with.

This file seems to be the problem: https://github.com/saltstack/salt-ext-modules-vmware/blob/main/tests/integration/nsxt_config.json

The way the config is loaded also is not following the more typical pattern.

Of course, as we've discussed in the past, the scraper approach is less desirable. If it's possible to gather the required values from the environment it's acceptable to write something like this:

@pytest.fixture
def nsxt_config():
    org_id = os.environ.get("VMWARE_NSXT_ORG_ID")   # assuming NSXT is different than NSX
    ...
    assert org_id, "To run NSX-T tests, set VMWARE_NSXT_ORG_ID environment variable"
    assert refresh_key, "To run NSX-T tests, set VMWARE_REFRESH_KEY environment variable"  # unless the refresh key would be different
    username = do_something(org_id, refresh_key, ...)
    ...
    yield {"username": username, "org_id": org_id, ...}

Obviously these values should be documented, and as much as possible helpers should be provided so that someone who has access to NSX-T should be able to get the required information without outside help.

[kdsalvy]

Hi @waynew we can modify the way config is loaded. However, we will still need to replace the config file ( https://github.com/saltstack/salt-ext-modules-vmware/blob/main/tests/integration/nsxt_config.json) with actual values. I'm not sure how to fetch something from the environment if the env related values are not provided in the config.

I will add the instructions to readme file, to add the top level server and credentials. HTH

[waynew]

@kdsalvy are you going to make the changes to this PR or should we go ahead and close it?

[kdsalvy]

Hi @waynew , do we need any change in the IT? I have verified it is working fine, on adding the configuration. Any other changes can be taken up as separate PR.