Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fix nightlys (incorrect old repo path) #1951

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

ITJamie
Copy link
Contributor

@ITJamie ITJamie commented Jul 22, 2023

What does this PR do?

Add testing of nightly build installs to catch issues with gpg logic etc

ive just noticed that the nightly paths are wrong.
they should be using:

but are using:

the items in the second path are old (from feb)

@ITJamie ITJamie marked this pull request as ready for review July 22, 2023 23:30
@ITJamie ITJamie changed the title Add nightlys WIP: Add nightlys Jul 22, 2023
@ITJamie
Copy link
Contributor Author

ITJamie commented Jul 23, 2023

hmm. im struggling to figure out the logic for the debian/ubuntu nightlys.

https://repo.saltproject.io/salt-dev/master/latest/salt/py3/debian/10/amd64/minor/
there's a dir inside with a random build name.

the rhel based ones have a mirror.repo inside the minor folder to point to build name, the debian and ubuntu ones do not...

I've brought it in the releases slack channel. a "latest" symlink pointer inside "minor" would be useful for this
https://saltstackcommunity.slack.com/archives/C01R6B3CGAD/p1690071708455759

@ITJamie
Copy link
Contributor Author

ITJamie commented Jul 24, 2023

blocked by saltstack/salt#64700.

@ITJamie ITJamie changed the title WIP: Add nightlys WIP: fix nightlys (incorrect old repo path) Aug 3, 2023
@ITJamie
Copy link
Contributor Author

ITJamie commented Sep 5, 2023

blocked by saltstack/salt#64927

@ITJamie
Copy link
Contributor Author

ITJamie commented Jan 16, 2024

blocked by: saltstack/salt#65877

@dmurphy18
Copy link
Contributor

@ITJamie Are you still interested in this PR. The current release 2024-07012 has cleaned up a lot of the old cruff and wondering if still interested in doing this PR, if not, please consider closing it.

@ITJamie
Copy link
Contributor Author

ITJamie commented Jul 15, 2024

Im happy to rework it but theres still no upstream latest repo symlink to be able to sanely deploy repofiles with a fixed symlink path

@dmurphy18
Copy link
Contributor

@mgeggie
Copy link

mgeggie commented Jul 30, 2024

Would really like to see this PR merged as soon as possible. We have a Packer build that just broke while attempting to bootstrap Salt 3005 on Ubuntu 22.04, due to a mis-matched path in the script looking for SALT-PROJECT-GPG-PUBKEY-2023.gpg in our exact version distribution directory (https://repo.saltproject.io/salt/py3/ubuntu/22.04/amd64/minor/3005/SALT-PROJECT-GPG-PUBKEY-2023.gpg) instead of in https://repo.saltproject.io/salt/py3/ubuntu/22.04/amd64/SALT-PROJECT-GPG-PUBKEY-2023.gpg.

@dmurphy18
Copy link
Contributor

@ITJamie Are you still interested in this PR. The infrastructure has changes to packages.broadcom.com, and removed use of Kitchen, would need to rebase against latest develop branch.

The develop branch is now using Github actions, and you could base nightly of the release.yml, except for cutting a release.
If no longer interested, please consider closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants