codegen: add support for abstract classes #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abstract classes only contain static methods (they implement a static interface) and the code generation was failing because we were trying to generate their signature. The signature is used to create new instances of generic classes, so we can skip its generation on abstract classes. The commit also removes the class struct and its constructor, since they were unused. fixes #79
|
Thanks a lot! I spent some time trying to get this to work, but it helps if you're familiar with the codebase. In the meantime, I figured out I don't actually need WinRT for my use-case though, so I might not end up using this. Still, I'm sure someone else will! |
glerchundi
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract classes only contain static methods (they implement a static interface) and the code generation was failing because we were trying to generate their signature. The signature is used to create new instances of generic classes, so we can skip its generation on abstract classes.
The commit also removes the class struct and its constructor, since they were unused.
fixes #79