SALTO-7313: E2E fixes #7136
Open
SALTO-7313: E2E fixes #7136
+212
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IdoZakk
commented
Jan 20, 2025
| @@ -115,6 +126,14 @@ export const defaultDeployChange = async ({ | |||
| log.warn('Received unexpected response from deployChange: %o', response) | |||
| } | |||
| } | |||
| if ( | |||
| isAdditionOrModificationChange(change) && | |||
| response !== undefined && | |||
There was a problem hiding this comment.
This is for the transpiler, line 132 covers it as well
IdoZakk
commented
Jan 20, 2025
Comment on lines
-202
to
-205
| } else { | ||
| tab.originalFieldsIds = { | ||
| ids: [], | ||
| } |
There was a problem hiding this comment.
When fetching without tabs we do not create those fields so I made it the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a problem in the E2E- it did not apply changes to the instances
In the core we apply changes after a deployment of a change group on the instances, so references will have the valid values (for instance IDs). In the E2E we only copied the value of the ids for parents.
Following the change, which is in the first commit, a few bug were revealed. Each is fixed in a separate commit.
In the last commit I added another fix for the E2E, to perform the delete in the same groups of the additions as sometimes the order is important
Release Notes:
Jira Adapter:
User Notifications:
None