Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workaround for the links that have ampersands in them #48

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

max-arnold
Copy link
Contributor

@max-arnold max-arnold commented Aug 29, 2024

The & character is escaped into & by MyST and that breaks query parameters executablebooks/MyST-Parser#760

A possible workaround is to use <a href="...">...</a> for those links

A bigger question is how to fix that for future links that might be added

@max-arnold max-arnold requested a review from lkubb August 29, 2024 23:18
@max-arnold max-arnold force-pushed the fix-ampersand-links branch from 2fb41ba to 33e55bd Compare August 29, 2024 23:37
Copy link
Member

@lkubb lkubb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice (and surprising) find!

Not sure yet what to do about future instances of this. Options that come to mind:

  • Add a pre-commit hook
  • in the docs job, somehow s/&amp;amp;/&amp; in all built docs

@lkubb lkubb merged commit b053df1 into salt-extensions:main Aug 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants